Set point_source_ID per scan when exporting LAZ/LAS#428
Merged
Conversation
Each exported point now carries point_source_ID equal to its scan's index in point_clouds_container.point_clouds, so merged exports (Local/Global scan), Separate global scans, and trajectory exports remain attributable to their source scan. Capped at 65535 with a stderr warning when the session has more scans. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
michalpelka
approved these changes
May 13, 2026
Contributor
|
I like code, lets run CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
point_source_IDequal to the source scan's index inpoint_clouds_container.point_clouds, so merged exports remain attributable to their source scan.save_all_to_las), Separate global scans (laz/las) (save_separately_to_las→save_processed_pc), and Save all marked trajectories (save_trajectories_to_laz→exportLaz).unsigned short) with a stderr warning when the session contains more scans. Indexing follows position in the fullpoint_cloudsvector — hidden scans keep their original ID.Test plan
multi_view_tls_registration(CMake)..laz; verify in CloudCompare orlasinfo -histo point_sourcethat point_source_ID values match scan indices.🤖 Generated with Claude Code