Module creation and CLI interface cleaning#4342
Open
OliverStrait wants to merge 5 commits intoManimCommunity:mainfrom
Open
Module creation and CLI interface cleaning#4342OliverStrait wants to merge 5 commits intoManimCommunity:mainfrom
OliverStrait wants to merge 5 commits intoManimCommunity:mainfrom
Conversation
OliverStrait
commented
Jul 22, 2025
added 5 commits
July 31, 2025 19:23
generation.
- Module code does not know manim anymore
- Two CLI helper function in new cli_utils.py
- Commands are only place that has knowledge of
wider program
- Every CLI choise and desicion is moved inside
of Commands
Scene classes
- fixing typos and added full docstring - replace regex with python string split module_ops: - full docstrings, typo fixing - handling python internal type-madness with exceptions to please mypy commands: - docstrings, typos, more descriptive names - cleaning version fetch functionality
Use Scene and not type(self)
OliverStrait
force-pushed
the
module_import
branch
from
f151722 to
adfa870
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Cleaning and documenting Runtime module creation and Scene-class search
Version checker:
Motivation and Explanation: Why and how do your changes improve the library?
Related issue
#4264
Reviewer Checklist