Fix Error when calling .get_number_mobjects() with no arguments in NumberLine#4248
Open
irvanalhaq9 wants to merge 4 commits intoManimCommunity:mainfrom
Open
Fix Error when calling .get_number_mobjects() with no arguments in NumberLine#4248irvanalhaq9 wants to merge 4 commits intoManimCommunity:mainfrom
.get_number_mobjects() with no arguments in NumberLine#4248irvanalhaq9 wants to merge 4 commits intoManimCommunity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fix #4244
Motivation and Explanation: Why and how do your changes improve the library?
Calling
get_number_mobjects()inNumberLinewithout any arguments caused error.This PR resolves this issue (see: #4244).
Changes
get_numbers_to_display():add_numbers().get_number_mobjects():get_numbers_to_display()whennumbersis not provided.add_numbers():get_numbers_to_display()method. This allowsadd_number()to focus only on adding the number objects to the axis.get_number_mobjects().font_sizeandlabel_constructor, as these are already handled insideget_number_mobject().Links to added or changed documentation pages
No changes in the documentation: https://manimce--4248.org.readthedocs.build/en/4248/reference/manim.mobject.graphing.number_line.NumberLine.html#manim.mobject.graphing.number_line.NumberLine
Reviewer Checklist