Refactor: encapsulate WebServerConfig fields and add constructor - #5
Open
Rayato159 wants to merge 1 commit into
Open
Refactor: encapsulate WebServerConfig fields and add constructor#5Rayato159 wants to merge 1 commit into
Rayato159 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the encapsulation of
WebServerConfigby making theipandportfields private and exposing a clear constructor for external use.🔨 Changes:
ipandportare now privateWebServerConfig::new(ip: IpAddr, port: u16)for constructionDefaultimplementationWhy ?
As discussed in Issue #4, public fields can lead to:
This refactor helps establish a more robust and consistent API surface.
Releated Issue: #4
Let me know if you’d prefer accessor methods
ip,portadded as well, happy to include.PS. This is tested screenshot, I have changed from default
WebServerConfigfrom Addr: 127.0.0.1, Port: 8080 to Addr: 127.0.0.1, Port: 3000 and It's works.