Update MLH OAuth endpoints and bump gem patch version to 4.1.1 - #18
Merged
Conversation
Agent-Logs-Url: https://github.com/MLH/omniauth-mlh/sessions/69ee5d26-8e3b-4225-a5d8-ac2d78e336bf Co-authored-by: erinosher <4386583+erinosher@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MLH/omniauth-mlh/sessions/69ee5d26-8e3b-4225-a5d8-ac2d78e336bf Co-authored-by: erinosher <4386583+erinosher@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MLH/omniauth-mlh/sessions/fad989cc-26a4-430a-96cc-72ac8d662ecc Co-authored-by: erinosher <4386583+erinosher@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
erinosher
May 20, 2026 16:12
View session
erinosher
marked this pull request as ready for review
May 20, 2026 16:12
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the OmniAuth MLH OAuth2 strategy to use MLH’s new authorization/token endpoints, and bumps the gem patch version accordingly so consumers get the corrected defaults.
Changes:
- Updated
OmniAuth::Strategies::MLHclient_optionsto point to the newauthorize_urlandtoken_urlhosts. - Bumped gem version from
4.1.0to4.1.1and updated the version assertion spec. - Added a strategy spec asserting the configured OAuth endpoint URLs.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lib/omniauth/strategies/mlh.rb |
Updates default OAuth client endpoint configuration to new MLH hosts. |
spec/omni_auth/strategies/mlh_spec.rb |
Adds regression coverage for configured authorize/token URLs. |
lib/omniauth-mlh/version.rb |
Bumps gem version constant to 4.1.1. |
spec/omni_auth/mlh_spec.rb |
Updates version assertion to 4.1.1. |
.gitignore |
Ignores vendor/bundle (common Bundler path). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MLH/omniauth-mlh/sessions/b4e68677-023f-4ac5-8d88-b93480d6b899 Co-authored-by: erinosher <4386583+erinosher@users.noreply.github.com>
erinosher
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLH OAuth authorization and token exchange moved to new hosts, so the strategy defaults needed to be updated to avoid routing auth flows to deprecated endpoints. This PR also applies the corresponding semver patch release bump.
OAuth endpoint configuration
OmniAuth::Strategies::MLHclient options to use:https://www.mlh.com/oauth/authorizehttps://api.mlh.com/v4/oauth/tokensitewith the new authorization host.Versioning
4.1.0to4.1.1(patch).Regression guard