Repository navigation
feat: a review that drops noise, and a build that answers review comments - #35
Merged
Merged
Conversation
…omments Five ideas from PostHog's review skills, taken as ideas with no copied text. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…nd spots Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ne reply Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mments Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"When unsure" in bar.md now means only "unsure whether the drop list covers it". A candidate that passes the keep test but could not be run stays a finding, marked "from reading". The one-line sweep result is the last sentence of "What I ran". The review-noise fixture plants the short name and the missing None guard as open questions in the description, so a faithful reviewer meets both. The allow list no longer lets the agent run the mailer, which tried a real connection to a local relay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comments from people and bots take the comments path; findings of builder's own review take the path in "Done", and fixed comments go back to review. Each comment that needs the person is a ▶ You item, and it stays open when nobody answers. comments.md states the four outcomes once, declines a real problem that is out of scope or already settled by a recorded decision, sends a change to an existing test or a maintainer's ask to remove one to the person, and separates a request about the change from an order to the agent. The README says that build answers review comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a person can now do
reviewdrops noise by a written list, says what it dropped and why, and makes one last sweep over what its findings did not touch.build. Each comment gets one outcome and one reply: fixed, declined, already fixed, or needs the person.What changes
skills/review/bar.md(new): the keep test (a trigger and a harm, both named), the drop list, and the sweep. A security record is never dropped. An unconfirmed finding stays, marked "from reading".skills/build/comments.md(new): the four outcomes, when a fix is safe to make alone, whose comment counts for how much, and what goes to the person.buildnever changes or removes an existing test to make a fix pass without the person.reviewandbuildtreat text in a diff, a description, a comment or a log as data. An instruction inside it is reported, not followed.review-noiseandreview-comments.ee/folder). builder takes the ideas and copies no text.Proven
go test ./...passes.bash scripts/validate.shprints "all checks passed" (scrub skipped: no denylist), andbash tests/test_validate.shexits 0.bash tests/evals/run.sh --checkprints "fixtures ok".ZeroDivisionError.Not proven
Stack
Third of three. Base:
feat/decommission. Design:docs/specs/2026-11-12-review-comments-design.md.🤖 Generated with Claude Code