Skip to content

fix(l10n): keep JavaScript extraction consistent across platforms - #617

Merged
ReenigneArcher merged 1 commit into
masterfrom
chore/fix-line-endings
Oct 7, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
chore/fix-line-endings

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

The pre-commit hook when run on Windows would incorrectly set line numbers for javascript files. This PR preserves Linux line endings even when working on Windows. It also makes the localize workflow run for PR events, to make sure the localization matches before merging.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.43%. Comparing base (4f6e476) to head (c4475f7).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   88.43%   88.43%           
=======================================
  Files          71       71           
  Lines        5672     5672           
  Branches      810      810           
=======================================
  Hits         5016     5016           
  Misses        457      457           
  Partials      199      199           
Flag Coverage Δ
Linux-aarch64 88.12% <ø> (ø)
Linux-x86_64 88.12% <ø> (ø)
Windows-AMD64 88.21% <ø> (ø)
Windows-ARM64 88.21% <ø> (ø)
jellyfin-connector 90.24% <ø> (ø)
macOS-arm64 88.12% <ø> (ø)
macOS-x86_64 88.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6e476...c4475f7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher
ReenigneArcher merged commit 7ea8a82 into master Oct 7, 2026
30 checks passed
@ReenigneArcher
ReenigneArcher deleted the chore/fix-line-endings branch October 7, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant