Add .nvmrc pinning Node 24 - #851
Open
krejko wants to merge 1 commit into
Open
Conversation
package.json requires node ^24.15.0 and CONTRIBUTING lists Node 24.x as a prerequisite, but there is nothing for nvm to read. Contributors using nvm have to know the version and pass it manually. Track the major only, so it stays consistent with the existing engines range rather than pinning a patch that would need bumping. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsondeclares"node": "^24.15.0"and CONTRIBUTING lists Node 24.x as a prerequisite, but there is no.nvmrc, so nvm users have to know the version and pass it by hand (nvm use 24) on every shell.Adding one makes a bare
nvm useresolve correctly from the repo root and fromfe/andlistenarr.api/, since nvm walks up the tree.Changes
Added
.nvmrccontaining24Testing
nvm usein a clean shell selects Node 24 from the repo root and from subdirectories. No build or runtime behaviour is affected.Notes
Tracks the major only rather than a full patch version, so it stays consistent with the existing
^24.15.0engines range instead of needing a bump on every Node patch release.🤖 Generated with Claude Code