Moved Edit/Delete/Save buttons to the navigation bar#112
Open
reactorcoremeltdown wants to merge 30 commits intoLinbreux:mainfrom
Open
Moved Edit/Delete/Save buttons to the navigation bar#112reactorcoremeltdown wants to merge 30 commits intoLinbreux:mainfrom
reactorcoremeltdown wants to merge 30 commits intoLinbreux:mainfrom
Conversation
reactorcoremeltdown
changed the title
Owner
|
hi @reactorcoremeltdown, love to hear that. This a handy feature! Would it be possible to move the searchbar back to the left in desktop mode and the icons to the right? Maybe it's also more logical this order: new, edit, del. Having these buttons in the header is indeed way more logical. Thanks for implementing that! |
Contributor
Author
|
@Linbreux I tried to move things around as you have suggested. Looks better now? |
Owner
|
I like it! Only the collapsed navbar looks a bit cluttered. I also tried to fix it for the pas 2 hours, bu can't seemed to get it right... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Making editing buttons accessible when scrolling the contents. Also providing more space for filename + file path.
Details
I use wikmd a lot, also on the go, and I have noticed that on some long pages I have to scroll to top or to bottom to access Edit/Save buttons. This is somewhat inconvenient as I am losing the context as a result. This PR makes use of the fixed to top navigation bar and puts all important buttons there, making it possible to edit and save pages in the middle.
As usual, if the change does not fit into design language of the project, please feel free to reject the PR. I am also open to any suggestion.
Checks
docs/<corresponding file>