Repository navigation
📧 fix: Log User IDs Instead of Emails in Admin Panel Auth Flow - #17032
Merged
Merged
Conversation
5 tasks done
berry-13
changed the title
berry-13
added this pull request to stack #17034
October 12, 2026 18:00
berry-13
marked this pull request as ready for review
October 12, 2026 18:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0a3ee0e84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
berry-13
force-pushed
the
berry-13/admin-oauth-email-logs
branch
from
October 12, 2026 20:35
c0a3ee0 to
20744a5
Compare
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every admin-panel login wrote the user's email address into the logs. The OAuth callback logged it at info level when redirecting with an exchange code, and the admin exchange, token refresh and
requireAdminpaths logged it too. The central redaction format has no email rule, so the address reached the log sink in plaintext. These log lines now carry the opaque user id instead, which is enough to trace a login.Type of change
Testing
Tested environments/configuration:
Automated tests:
admin.spec.tsandrefresh.spec.tsnow assert the user id is logged and the email is not.npx jest src/middleware/admin.spec.ts src/authin packages/api: all pass.npx tsc --noEmit -p packages/api/tsconfig.json, eslint and prettier on changed files: clean.admin-auth-log-ids.spec.ts: an unknown admin exchange code still gets 401 with no user data, and a non-admin is still denied/api/admin/verifywithout the response echoing their email (desktop light, dark and mobile: pass).Checklist