fix: correct misleading error message#137
Open
rhkrwngud445 wants to merge 1 commit intoLexiLabs-App:v1.1.1from
Open
fix: correct misleading error message#137rhkrwngud445 wants to merge 1 commit intoLexiLabs-App:v1.1.1from
rhkrwngud445 wants to merge 1 commit intoLexiLabs-App:v1.1.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the clarity of error messages across the library's ad handlers. The goal is to provide developers with precise, actionable guidance when they encounter runtime exceptions related to uninitialized or unloaded ad states.
Context
As identified in our contribution plan, current error messages occasionally blend the names of the UI Composables (e.g.,
RewardedAd) with their corresponding Logic Handlers (e.g.,RewardedAdHandler). Since theload()andsetListeners()methods reside on handler instances rather than the Composable functions, this update ensures developers are directed to the correct object for resolution.Key Changes
rewardedAdHandler.load()).RewardedInterstitialAdHandlerwhere error messages previously referred to it as a genericRewardedAd.Affected Components
RewardedInterstitialAdHandler,InterstitialAdHandler,RewardedAdHandler,NativeAdHandlerImpact
These changes eliminate ambiguity during the debugging process, allowing developers to quickly resolve state-related issues by following the intuitive instructions provided directly within the exception messages.