feat: add MasonryLegendList - #506
Open
maxwellyoung wants to merge 5 commits into
Open
maxwellyoung wants to merge 5 commits into
maxwellyoung wants to merge 5 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08e90d96c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Map the optional masonry entrypoint in the Expo example Metro resolver so the native fixture bundles the local source instead of relying only on TypeScript paths.
Merge current main into the existing masonry contribution and preserve the validated candidate tree. Add independent-column visibility tracking so tall cards survive reverse scrolling, small scrolls cannot skip newly visible cards, and offscreen gaps do not inflate the recycled pool. Include interactive native and web fixtures covering recycled identity, prepend and append, column changes, and dynamic tall cards. Validated with 1669 tests, TypeScript, lint, package build, browser checks, and iOS and Android debug runtime interactions.
Keep the pending column-change flag until its layout effect consumes it. React StrictMode replay previously cleared the flag and left a three-column masonry arrangement after switching to four columns. Add repeatable Chromium and WebKit E2E coverage at two viewport widths, including actual column placement, recycled identity, prepend anchoring, append, tall-card reverse scrolling and reset. Run the checks in GitHub Actions and retain failure traces.
Drive real browser wheel input instead of assigning DOM scrollTop before list bookkeeping observes it. Wait for stable rendered geometry before issuing the next gesture, require each gesture to retain its direction after settlement, and retain precise final landing, identity, overlap and visibility assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23.
What this adds
MasonryLegendListfrom the separate@legendapp/list/masonryentrypointThe initial API is deliberately vertical-only. Column spans and
overrideItemLayoutare not supported.Bundle isolation
The masonry algorithm is only present in the optional integration bundle:
masonry.mjs: 4.8 KBmasonry.js: 5.4 KBIt imports
@legendapp/list/react-nativerather than repackaging core. The postbuild integrity check now covers the masonry entrypoint, and the publish dry run includesmasonry.d.ts,masonry.js, andmasonry.mjs.Reproduce
Web:
bun install cd example-web bun install bun run dev:fixturesThen open
/masonry. The fixture uses 80 dynamically measured cards and recycling across three columns.Native:
cd example bun install bun run ios:fixturesOpen Data & Layout > Masonry.
Verification
bun test: 1,519 passed, 0 failedbun run tsc: source, native example, and web example passedbun run build: Biome, tsup, declarations, and postbuild integrity passed@legendapp/list/masonrynative fixture route