refactor!: remove ltk_pki#171
Merged
Merged
Conversation
Brings in WAD signature checks and preservation plumbing (toc_sha256, verify_signature, prebuilt signature/checksum in the builder) needed by the upcoming ltk_sig crate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Patched overlay WADs now carry the source WAD's header signature and checksum verbatim (via ltk_wad 0.3.0 accessors) instead of zeroed placeholders. The signature covers the original TOC, not the patched one - it is preserved as provenance so ltk_sig's merged-WAD verification can recover the Riot-signed original TOC from overlay files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The x509/CMS-based PKI prototype is retired; a successor design based on COSE/CWT tokens will land separately. BREAKING CHANGE: the ltk_pki crate is no longer published from this workspace. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Crauzer
previously approved these changes
Jul 4, 2026
moonshadow565
dismissed
Crauzer’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.