Document URL env vars as staging-only for Amendable developers - #2
Merged
Conversation
Customer docs hardcode production hosts. README still shows AMENDABLE_API_URL only for hitting staging while developing Amendable. Co-authored-by: Fang-Pen Lin <hello@fangpenlin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMENDABLE_API_URLandAMENDABLE_APP_URLare not customer configuration. Production is the default. The only reason to set them is when developing Amendable against staging (amendable login --stagingor the env vars).Customer docs in amendable-docs now hardcode production hosts. This README no longer lists the URL env vars as general overrides.
Companion: https://github.com/LaunchPlatform/amendable-docs/pull/10