Skip to content

Remove global npm upgrade from deploy-nodejs/deploy-wasm jobs #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 2 commits into from
Jul 10, 2026
Merged

Remove global npm upgrade from deploy-nodejs/deploy-wasm jobs #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ab33e
Remove global npm upgrade from deploy-nodejs/deploy-wasm jobs
adsharma Jul 9, 2026
f231ed2
Guard httplib set_ca_cert_path call under CPPHTTPLIB_OPENSSL_SUPPORT
adsharma Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/build-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,9 +419,6 @@ jobs:
node-version: "22"
registry-url: "https://registry.npmjs.org"

- name: Upgrade npm
run: npm install -g npm@latest

- name: Package Node.js API (main + per-platform sub-packages)
run: node package
working-directory: tools/nodejs_api
Expand Down Expand Up @@ -524,9 +521,6 @@ jobs:
node-version: "20"
registry-url: "https://registry.npmjs.org"

- name: Upgrade npm
run: npm install -g npm@latest

- name: Show tarball contents
run: tar -tvf lbug-wasm.tar.gz
working-directory: tools/wasm
Expand Down
2 changes: 2 additions & 0 deletions src/extension/extension_installer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ void configureSSLCerts(httplib::Client& client, const ExtensionRepoInfo& repoInf
return;
}
if (auto caCertPath = ExtensionUtils::getCaCertPath()) {
#ifdef CPPHTTPLIB_OPENSSL_SUPPORT
client.set_ca_cert_path(caCertPath->caCertFilePath, caCertPath->caCertDirPath);
#endif
}
}

Expand Down
Loading