Bbq support#26
Open
akhauriyash wants to merge 4 commits into
Open
Conversation
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: akhauriyash <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable xLLM partial-RoPE layout wiring for BBQ 375B training.
Changes
--xllm-partial-rope-layouttoscripts/models/xllm-375B.shmiles_plugins/mbridge/xllm.pyto:rotary_percentfromrope_head_dim / head_dimxllm_partial_rope_layoutwhenrope_head_dim * 2 == head_dimWhy
xLLM 375B uses partial RoPE with
rope_head_dim=64andhead_dim=128. The trainer needs to opt into the Megatron-LM xLLM partial-RoPE path so its logprobs match the HF/SGLang reference layout.Validation
python3 -m py_compile miles_plugins/mbridge/xllm.pybash -n scripts/models/xllm-375B.shgit diff --check