Fix usage of fract_base_dir and val_split#63
Draft
michaelmckinsey1 wants to merge 11 commits intoLBANN:mainfrom
Draft
Fix usage of fract_base_dir and val_split#63michaelmckinsey1 wants to merge 11 commits intoLBANN:mainfrom
fract_base_dir and val_split#63michaelmckinsey1 wants to merge 11 commits intoLBANN:mainfrom
Conversation
Collaborator
michaelmckinsey1
commented
Apr 30, 2026
michaelmckinsey1
commented
- depends on Implement CosineAnnealingWarmRestarts LR Scheduler #61
- Fixes setting fractal_dir. This was being ignored before
- Fixes setting val_split. This was not creating a new dataset because it wasn't in the hash
- Undoes val_batch_size. We should use the same for train and val
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.