[mini] [bugfix] Remove Default Argument in abcd.py#483
Open
rob-shalloo wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks, we'll need to fix CI before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default argument in
abcd.pyis causing issues when trying to use a numpy backend on a machine which is capable of cupy.The default argument is evaluated at class definition time — i.e., at import. So even though you might be trying to run with a NumPy backend, the xp variable is already bound to CuPy when the module is parsed, and CuPy immediately tries to allocate a GPU array. In my case I did have cupy, but an old driver (hence wanting to use numpy backend).