[pre-commit.ci] pre-commit autoupdate#463
Open
pre-commit-ci[bot] wants to merge 2 commits into
Open
Conversation
d8081d6 to
3bba968
Compare
672a2d2 to
b48fb07
Compare
b48fb07 to
abe4db3
Compare
374b9e8 to
085936a
Compare
085936a to
9f4630d
Compare
c1ecafb to
fd30207
Compare
6aa694e to
8360405
Compare
8360405 to
b0b5568
Compare
08b2ef5 to
26953d3
Compare
dc23715 to
84bd28b
Compare
2e162c8 to
67460ef
Compare
23ff8a3 to
24a8f67
Compare
05fa0c1 to
1699cbf
Compare
a128353 to
c01d5ca
Compare
111f336 to
f83b994
Compare
8ce18d6 to
55bdd32
Compare
MaxThevenet
approved these changes
Apr 24, 2026
Contributor
|
@CriMariani this PR makes a small change to ChromaticLens, namely in the documentation at https://lasydoc--462.org.readthedocs.build/en/462/api/optical_elements/chromatic_lens.html it replaces R1 = 114.5e-3 # 1st ROC
t1 = 3.4e-3 # lens thickness
R2 = -114.5e-3 # 2nd ROC
nFS = (
lambda x: (
1
+ 0.6961663 / (1 - (0.0684043 / x) ** 2)
+ 0.4079426 / (1 - (0.1162414 / x) ** 2)
+ 0.8974794 / (1 - (9.896161 / x) ** 2)
)
** 0.5
)
laser.apply_optics(Lens2(R1=R1, R2=R2, d=t1, n_func=nFS))with R1 = 114.5e-3 # 1st ROC
t1 = 3.4e-3 # lens thickness
R2 = -114.5e-3 # 2nd ROC
nFS = lambda x: (
(
1
+ 0.6961663 / (1 - (0.0684043 / x) ** 2)
+ 0.4079426 / (1 - (0.1162414 / x) ** 2)
+ 0.8974794 / (1 - (9.896161 / x) ** 2)
)
** 0.5
)
laser.apply_optics(Lens2(R1=R1, R2=R2, d=t1, n_func=nFS))Could you confirm that it still works? I guess it should, but this is not in CI. |
eaee3fe to
44f5942
Compare
bae3044 to
ff7db03
Compare
9f5feaf to
3f3094a
Compare
9e9c1e7 to
402160b
Compare
e349e07 to
ed5284a
Compare
e71522d to
ad35a59
Compare
updates: - [github.com/Lucas-C/pre-commit-hooks: v1.5.5 → v1.5.6](Lucas-C/pre-commit-hooks@v1.5.5...v1.5.6) - [github.com/astral-sh/ruff-pre-commit: v0.13.2 → v0.15.20](astral-sh/ruff-pre-commit@v0.13.2...v0.15.20) - [github.com/mgedmin/check-manifest: 0.50 → 0.51](mgedmin/check-manifest@0.50...0.51)
89cbc3b to
c0a8b6c
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: