Improve training performance on large datasets like MGnify - #35
Open
idavi-bcs wants to merge 3 commits into
Open
Improve training performance on large datasets like MGnify#35idavi-bcs wants to merge 3 commits into
idavi-bcs wants to merge 3 commits into
Conversation
…ains that are actually present
…ding time for MGnify from 2 hrs to 2 sec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34 .
Addresses three bottlenecks that appear when training with datasets that have many wildtype domains, with a few mutations each:
MegaScaleDataset, slow explicit loops have been replaced with fast vectorized operations.I've also added support for batches > 1. The original code had one wildtype PDB per batch, with hundreds of mutations. With datasets like MGnify where each wildtype has only a few mutations, this is insufficient to calculate meaningful gradients. Larger batch sizes also reduce the number of steps per epoch, which diminishes the importance of the Spearman performance issue.