fix(release): keep pre-1.0 breaking changes on minor bumps - #197
Merged
Conversation
The `focus_order` fix in #195 carried a `BREAKING CHANGE:` footer, and release-please's default for a 0.x project is to treat that as the signal to cut 1.0.0 -- so PR #196 opened as "chore(main): release 1.0.0". Nothing about that branch was a decision to declare the API stable. `bump-minor-pre-major` makes a breaking change bump the minor while the project is on 0.x, which is what SemVer allows pre-1.0 and what VERSIONING.md now documents. `bump-patch-for-minor-pre-major` stays off: a feature should still move the minor, not hide in a patch. 1.0.0 becomes a deliberate act -- a commit that raises the version explicitly, after the readiness audit -- rather than a side effect of a commit footer. Signed-off-by: Sean Mauk <seanmauk@krakennetworks.com>
se-jo-ma
force-pushed
the
fix/release-please-pre-1.0-bumps
branch
from
August 20, 2026 13:30
b58c333 to
7dd0b8a
Compare
krakennetworks
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-pleaseopened #196 as chore(main): release 1.0.0. Nothing on the branch it batched was a decision to declare the API stable — thefocus_orderfix in #195 carried aBREAKING CHANGE:footer, and release-please's default for a 0.x project reads that as the signal to cut 1.0.0.This sets two options on
release-please-config.json:bump-minor-pre-major: true— a breaking change bumps the minor while the project is on 0.x, which is what SemVer allows pre-1.0.bump-patch-for-minor-pre-major: false— a feature still moves the minor rather than hiding in a patch.1.0.0 becomes a deliberate act — a commit that raises the version explicitly, after a readiness audit — instead of a side effect of a commit footer.
Effect on #196
Once this lands, release-please recomputes the pending batch and #196 retargets from 1.0.0 to 0.9.0. That also clears its current red check:
check_version_sync.pyreportsversion skew: pyproject.toml=1.0.0 CHANGELOG.md=0.8.0, because the CHANGELOG has no 1.0.0 heading to match.Merge this first, then release 0.9.0.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ro3WQQ1Dk76zrDmTEqygRA