Repository navigation
Conversation
Author
|
Closing for now so the approach can be discussed in #221 first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #221
filter,filterIndexed,filterMultiIndexed,filterNot,distinctBy, andpartitioninIteratingNDArray.ktwere inferring the return array'sdtypeby callingDataType.of(list.first()). When the filtering predicate matched zero elements,list.first()threwNoSuchElementExceptioninstead of returning an empty array of the parent array's type.Additionally, in
ndarrayCommon(constructors.kt),val dtypeFromFirst = DataType.of(elements.first())was evaluated eagerly even when an explicitdtypewas supplied, causing crashes on empty collections.This PR uses the parent array's
this.dtypedirectly in these operations and lazily resolvesdtypeinndarrayCommon. Added regression tests for empty filtering across all operations.