Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

migrate anko commons(include v4, v7) to androidx#735

Open
phxnirvana wants to merge 12 commits into
Kotlin:masterfrom
phxnirvana:dev-androidx-migration
Open

migrate anko commons(include v4, v7) to androidx#735
phxnirvana wants to merge 12 commits into
Kotlin:masterfrom
phxnirvana:dev-androidx-migration

Conversation

@phxnirvana

Copy link
Copy Markdown

No description provided.

Comment thread build.gradle Outdated
ext.androidx_legacy_version = '1.0.0'
ext.androidx_appcompat_version = "1.0.2"
ext.androidx_annotation_version = '1.0.2'
ext.androidx_constrainlayout_version = "1.1.3"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: androidx_constraintlayout_version - but also, for my own edification, are these actually used anywhere? I don't see them referenced anywhere else but I may be missing something...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow, I forget to change the constraint-layout module...
already added now

@mo3in

mo3in commented Apr 24, 2019

Copy link
Copy Markdown

what happen now? @4u7 @yanex

@4u7 4u7 self-assigned this May 13, 2019
@guger

guger commented Sep 8, 2019

Copy link
Copy Markdown

I'd really appreciate seeing this pull request merged and released!

@jlberrocal

Copy link
Copy Markdown

seems like Anko project is dead, IntelliJ have no interest in this open source project

@BejanAlina

Copy link
Copy Markdown

@jlberrocal is this official ? Would be nice if at least this pull request is merged, if not deployed to another repo

@jlberrocal

Copy link
Copy Markdown

is not official, but if you take a look to the last change date you can infer so.

@Makentoshe

Copy link
Copy Markdown

If you want to update anko to androidx, you must also update generator. Regenerate all apis and update tests.

@phxnirvana

Copy link
Copy Markdown
Author

I think anko is already deprecated, since google has produced android-ktx.
I tried to update all, but generator cannot generate some of the interface.
And I don't have enough time to study and modify the generator for now, should I just close this pr?

@Makentoshe

Copy link
Copy Markdown

As a know, the maintainers has no time for it - they all are littered with work and other projects. I'm trying to do something with generator, but it has some underwater rocks. This pr may be usefull in a future

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants