test(viewer): web_exports proptest surface (WBS-6.2 #437) - #441
test(viewer): web_exports proptest surface (WBS-6.2 #437)#441KooshaPari wants to merge 1 commit into
Conversation
Adds `crates/sl-viewer/tests/properties_viewer_web_exports.rs` with
11 proptest properties pinning `WebExportProvider` and
`web_export_roots_with_env` reductions:
* `WebExportProvider::label`:
* Non-empty.
* Free of tabs / newlines / double-spaces (well-formed for badge UI).
* Distinct per variant (no accidental aliasing).
* `WebExportProvider::corpus`:
* Total — every variant maps to a `Corpus::ChatGptWeb | ClaudeWeb |
GeminiWeb` value (no panics, no fallback).
* Injective — distinct providers map to distinct corpora.
* `WebExportProvider::default_subdir`:
* Non-empty.
* Distinct per variant.
* Equals `label()` — `~/Downloads/<subdir>` lines up with the
user-facing provider name.
* `web_export_roots_with_env(home, None)`:
* Empty set when `home` is non-existent.
* Returns the subset of defaults whose `Downloads/<subdir>` path
exists on disk, exactly once each, in default order.
* Returns all three documented providers when all default dirs exist.
Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 56 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:L
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| let corpus = provider.corpus(); | ||
| prop_assert!(matches!( | ||
| corpus, | ||
| Corpus::ChatGptWeb | Corpus::ClaudeWeb | Corpus::GeminiWeb | ||
| )); | ||
| } |
There was a problem hiding this comment.
Suggestion: The corpus properties only check membership and injectivity, so a permutation such as mapping ChatGpt to Corpus::ClaudeWeb would still pass. Assert each provider's exact expected corpus to prevent loading exports under the wrong corpus identity. [logic error]
Severity Level: Major ⚠️
- ⚠️ Corpus regression tests accept provider identity permutations.
- ❌ Exports could be loaded under the wrong corpus identity.
- ⚠️ Provider-specific filtering and reporting could become incorrect.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_web_exports.rs
**Line:** 87:92
**Comment:**
*Logic Error: The corpus properties only check membership and injectivity, so a permutation such as mapping `ChatGpt` to `Corpus::ClaudeWeb` would still pass. Assert each provider's exact expected corpus to prevent loading exports under the wrong corpus identity.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| let existing_path = tmp.join("Downloads").join(provider.default_subdir()); | ||
| std::fs::create_dir_all(&existing_path).expect("mkdir provider"); | ||
|
|
||
| let roots = web_export_roots_with_env(&tmp, None); | ||
| prop_assert_eq!(roots.len(), 1); |
There was a problem hiding this comment.
Suggestion: This test verifies discovery only for directory entries, but web_export_roots_with_env accepts any existing filesystem entry while load_web_export_corpus requires a directory and calls read_dir. Add a regular-file case and assert the intended behavior, otherwise the test suite will not catch discovery returning an unusable root. [incomplete implementation]
Severity Level: Major ⚠️
- ⚠️ Default discovery accepts unusable regular-file roots.
- ❌ Web export loading fails for that provider.
- ⚠️ User exports may be skipped with an error.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_web_exports.rs
**Line:** 173:177
**Comment:**
*Incomplete Implementation: This test verifies discovery only for directory entries, but `web_export_roots_with_env` accepts any existing filesystem entry while `load_web_export_corpus` requires a directory and calls `read_dir`. Add a regular-file case and assert the intended behavior, otherwise the test suite will not catch discovery returning an unusable root.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
|
Closing due to merge conflicts. |
User description
Summary
Adds
crates/sl-viewer/tests/properties_viewer_web_exports.rswith 11 proptest properties pinning theWebExportProviderreductions andweb_export_roots_with_envdiscovery helper (WBS-6.2 #437, redux after the operator closed the original PR due to merge conflicts with #433's timeline surface).WebExportProvider::label(3 properties) — non-empty, well-formed (no tabs/newlines/double-spaces), distinct.WebExportProvider::corpus(2 properties) — total over the three*WebCorpus variants; injective.WebExportProvider::default_subdir(3 properties) — non-empty, distinct, equalslabel().web_export_roots_with_env(3 properties) — empty set for missing home; returns the existing-default subset; returns all three providers when all defaults exist.Validation
cargo test -p sl-viewer --test properties_viewer_web_exports --features "desktop parquet" --locked— 11 passedcargo clippy -p sl-viewer --test properties_viewer_web_exports --features "desktop parquet" --locked -- -D warnings— cleancargo fmt --all --check— cleanRebase status
This branch was rebased onto
origin/mainafter #433 (timeline) was merged. Conflicts inCHANGELOG.md,docs/ops/WBS.md,docs/ops/TRACEABILITY.jsonwere resolved by keeping both #433 and #437 entries.CodeAnt-AI Description
Add property coverage for viewer web-export discovery and provider mappings
What Changed
Impact
✅ Fewer web-export configuration regressions✅ Consistent provider names and download folders✅ Reliable discovery of available export folders💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.