Skip to content

fix(cli): restrict timeout cleanup to tracked child - #124

Closed
KooshaPari wants to merge 1 commit into
codex/pr117-timeout-fixesfrom
codex/phenocompose-safe-timeout-20260805
Closed

fix(cli): restrict timeout cleanup to tracked child#124
KooshaPari wants to merge 1 commit into
codex/pr117-timeout-fixesfrom
codex/phenocompose-safe-timeout-20260805

Conversation

@KooshaPari

Copy link
Copy Markdown
Owner

Summary

  • remove Windows process-tree and WSL distribution-wide timeout cleanup from the Podman command runner
  • reap only the exact Rust Child handle created for the bounded command
  • preserve fail-closed timeout diagnostics and the existing API/error contract

This is intentionally stacked on PR #119. No container, WSL, provider, or interactive-session actions were performed.

Validation

  • cargo check --manifest-path crates/phenocompose-cli/Cargo.toml --locked --target-dir C:\\Temp\\phenocompose-safe-timeout-target: pass
  • cargo test --manifest-path crates/phenocompose-cli/Cargo.toml --locked --target-dir C:\\Temp\\phenocompose-safe-timeout-target --no-run: pass (test binaries compiled; tests not executed because timeout tests intentionally exercise child termination)
  • git diff --check: pass
  • bounded source audit: no taskkill, WSL terminate, process-tree, or distro-wide cleanup symbols remain; only tracked Child handle cleanup remains
  • repository-wide cargo fmt --check: pre-existing unrelated rustfmt drift; no unrelated formatting changes applied

No merge, release, runtime start, process cancellation, or provider request performed.

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@KooshaPari

Copy link
Copy Markdown
Owner Author

Closing stale draft (audit cleanup 2026-08-19). Reopen if still relevant.

@KooshaPari KooshaPari closed this Aug 19, 2026
@mergify mergify Bot added the rust Pull requests that update rust code label Aug 19, 2026
@KooshaPari
KooshaPari deleted the codex/phenocompose-safe-timeout-20260805 branch August 21, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant