feat: Added changes to support CRUD oprn for graphql ratelimiting cos…#1937
feat: Added changes to support CRUD oprn for graphql ratelimiting cos…#1937shivaygupta-dotcom merged 29 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1937 +/- ##
==========================================
+ Coverage 32.53% 32.57% +0.04%
==========================================
Files 77 77
Lines 8758 8758
==========================================
+ Hits 2849 2853 +4
+ Misses 5713 5710 -3
+ Partials 196 195 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
fix for CI is already raised by @Prashansa-K in this PR |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 27577964 | Triggered | Generic Password | fb97172 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.4/credentials.expected.yaml | View secret |
| 27577956 | Triggered | Generic Password | fb97172 | tests/integration/testdata/sync/047-basic-auth-skip-hash/expected-dump.yaml | View secret |
| 27577949 | Triggered | Generic High Entropy Secret | a8d4747 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.14+/plugin-partial-2.yaml | View secret |
| 30400066 | Triggered | Generic High Entropy Secret | a8d4747 | tests/integration/testdata/diff/004-no-diff-plugin/kong.yaml | View secret |
| 27577959 | Triggered | Generic Password | a8d4747 | tests/integration/testdata/dump/008-sanitizer/consumergroup-plugins313.expected.yaml | View secret |
| 27577938 | Triggered | Generic High Entropy Secret | a8d4747 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.14+/credentials.expected.yaml | View secret |
| 27577959 | Triggered | Generic Password | a8d4747 | tests/integration/testdata/dump/008-sanitizer/consumergroup-plugins314.expected.yaml | View secret |
| 27577943 | Triggered | Generic High Entropy Secret | a8d4747 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.14+/credentials.expected.yaml | View secret |
| 27577949 | Triggered | Generic High Entropy Secret | a8d4747 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.14+/plugin-partial-2.expected.yaml | View secret |
| 27577943 | Triggered | Generic High Entropy Secret | a8d4747 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.14+/credentials.yaml | View secret |
| 27577959 | Triggered | Generic Password | a8d4747 | tests/integration/testdata/dump/008-sanitizer/consumergroup-plugins314.expected.yaml | View secret |
| 27577938 | Triggered | Generic High Entropy Secret | a8d4747 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.14+/credentials.yaml | View secret |
| 27577951 | Triggered | Generic Password | a8d4747 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.14+/credentials.yaml | View secret |
| 29995049 | Triggered | Generic Password | a8d4747 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.14+/credentials.expected.yaml | View secret |
| 27577959 | Triggered | Generic Password | a8d4747 | tests/integration/testdata/dump/008-sanitizer/consumergroup-plugins313.expected.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
7720846 to
a8d4747
Compare
493c76e to
75a585f
Compare
GH issue: #1909
jira: https://konghq.atlassian.net/browse/FTI-7307
Summary:
graphql_ratelimiting_cost_decorations.Supporting PRs:
GDR: Kong/go-database-reconciler#428
Go-kong:Kong/go-kong#608