fix(gateway-operator): changeable host network value for gw-operator#1237
Open
fix(gateway-operator): changeable host network value for gw-operator#1237
Conversation
|
|
mprokopc
changed the title
Author
|
@pmalek could you review this PR, please? |
pmalek
reviewed
Mar 3, 2025
Member
pmalek
left a comment
pmalek
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing this. This change looks good. Please add a changelog entry in https://github.com/Kong/charts/blob/main/charts/gateway-operator/CHANGELOG.md
Also, please make sure to rebase on the latest tip of main. I'm pretty sure the CI should trigger then
Member
|
@mprokopc Just checking in, do you still want to contribute this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding ability to change gateway-operator host network value by helm values. it's required when calico cni is used
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.