Improve images chapter #241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Vulkan-hpp enums, add explanations for important topics like staging, add notes in linear images improve wording, adjust code to be in line with what's actually used in the C++ files
Collaborator
Author
|
Can this be reviewed? Would like to see this merged. |
gpx1000
approved these changes
Jan 5, 2026
Contributor
gpx1000
left a comment
gpx1000
left a comment
There was a problem hiding this comment.
LGTM, very minor typo, but other than that, good to merge.
| There is actually a special type of image layout that supports all operations, `VK_IMAGE_LAYOUT_GENERAL`. | ||
| The problem with it, of course, is that it doesn't necessarily offer the best performance for any operation. | ||
| There is actually a special type of image layout that supports all operations, `vk::ImageLayout::eGeneral`. | ||
| But unless using certain extensions, which we don't do in the tutorial, using the general layout might come with a performance penalty is it may disable certain optimizations on some GPUs. |
Contributor
There was a problem hiding this comment.
penalty is -> penalty as. I didn't see any problems. this just caught my eye.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the images chapter by
Fixes #231