Repository navigation
Add SPV_INTEL_pause extension - #461
Merged
Merged
Conversation
vmaksimo
reviewed
Oct 22, 2026
| observable behavior of the program. The implementation can choose to ignore the | ||
| pause request. + | ||
| + | ||
| _Clocks_ must be a scalar 32-bit integer with unsigned integer type. |
Contributor
There was a problem hiding this comment.
The core spec doesn't use "unsigned integer type"; it either allows any integer type and states how the value is interpreted, or restricts the Signedness operand.
Two possible wordings, depending on the intent:
- Any 32-bit integer, interpreted as unsigned (like Shift in
OpShiftLeftLogical):
Suggested change
| _Clocks_ must be a scalar 32-bit integer with unsigned integer type. | |
| _Clocks_ must be a 32-bit integer type scalar. It is treated as unsigned. |
- Unsigned type required (like
OpConvertUToPtr); note this rejects a signedintoperand in Shader modules:
Suggested change
| _Clocks_ must be a scalar 32-bit integer with unsigned integer type. | |
| _Clocks_ must be a 32-bit scalar of integer type, whose _Signedness_ operand is 0. |
vmaksimo
approved these changes
Oct 28, 2026
vmaksimo
left a comment
vmaksimo
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but let's gather one more approval
bashbaug
approved these changes
Oct 28, 2026
Collaborator
|
Merging as discussed in the October 28th teleconference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.