Make Algorithm enum non_exhaustive - #494
Merged
Merged
Conversation
Collaborator
Author
|
Needs an MSRV bump probably |
arckoor
force-pushed
the
algo-non-exhaustive
branch
from
April 14, 2026 21:58
be40f88 to
9c16fcf
Compare
arckoor
force-pushed
the
algo-non-exhaustive
branch
from
May 12, 2026 12:58
9c16fcf to
e26a5bc
Compare
arckoor
force-pushed
the
algo-non-exhaustive
branch
from
May 12, 2026 13:01
e26a5bc to
23c78f3
Compare
Closed
Keats
reviewed
Jul 6, 2026
| } | ||
| AlgorithmParameters::OctetKeyPair(a) => match a.curve { | ||
| EllipticCurve::P256 | EllipticCurve::P384 | EllipticCurve::P521 => { | ||
| panic!("OctetKeyPair can't contain this curve type") |
Owner
There was a problem hiding this comment.
Since we return an error now in this function, can we not panic here and above?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #480.
Given that a few other PRs are wanting to add more algorithms and that that would be a breaking change anyway I figure this can just be merged when necessary.
Also addresses
Jwk::compute_digestnot returning aResult<>.