Open
Conversation
- Added new config field value `allowUsername` to support backwards compatibility - updated docs to discourage use of `username`
zemberdotnet
approved these changes
Mar 6, 2023
mscottford
force-pushed
the
config-field-username-check
branch
from
e969193 to
22f86d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows does not allow USERNAME env var to be set. This causes issues when a graph project is used in an on-prem scenario and a config field name
usernameis used.The changes here are to throw an exception when
usernameis specified.allowUsernameis a backwards compat option.