Repository navigation
Make issparse return false for an array whose parent is not an array - #1192
Merged
Merged
Conversation
ViralBShah
added a commit
that referenced
this pull request
Nov 22, 2026
Julia's CI stopped building 32-bit Windows on Nov 18 (JuliaCI/julia-buildkite#797, following the [Discourse announcement](https://discourse.julialang.org/t/phasing-out-julia-support-for-32-bit-windows/137912) that 1.13 is the last release with 32-bit Windows binaries). The last win32 nightly is `julia-publish` build 11438, for `dffa1584150`. **Before** `julia-latest-win32.zip` was last modified on Nov 18, while the other nightlies are current: ``` winnt/x86/julia-latest-win32.zip last-modified: Wed, 18 Nov 2026 09:16:40 GMT winnt/x64/julia-latest-win64.zip last-modified: Sun, 22 Nov 2026 12:29:29 GMT linux/x86/julia-latest-linux32.tar.gz last-modified: Sun, 22 Nov 2026 12:19:36 GMT ``` So `test (windows-latest, x86, nightly)` runs 1.15.0-DEV.831 while every other job runs DEV.904. It passes on #1192 without seeing the LinearAlgebra bumps that fail the other jobs, and on #1186 SparseArrays fails to precompile: ``` Julia Version 1.15.0-DEV.831 Commit dffa158415 (2026-11-18 07:58 UTC) ERROR: LoadError: UndefVarError: `_aliasparts` not defined in `LinearAlgebra` ``` **After** There is no Windows x86 job. The matrix lists all four runners under `os` with `julia-arch: default`, which `setup-julia` resolves to the runner's own architecture, and 32-bit Linux is the one `include` that sets an architecture: ``` test (ubuntu-latest, default, nightly) coverage test (windows-latest, default, nightly) test (macOS-latest, default, nightly) check-bounds=yes test (ubuntu-26.04-arm, default, nightly) test (ubuntu-latest, x86, nightly) ``` `julia-arch` stays a matrix key so that the x86 `include` adds a job instead of merging into the 64-bit Linux one. 32-bit builds are still tested on Linux, whose nightly is current, and `test/AGENTS.md` now names that job as the source of the 32-bit standard coverage. The required checks in the `main` ruleset follow the new job names: `test (windows-latest, x86, nightly)` is removed, and the macOS, Linux x64 and Windows x64 checks are now the `default` ones. Release branches test their own Julia release and are unaffected, so no backport. *This pull request was written by generative AI (Claude Code).* 🤖 Generated with [Claude Code](https://claude.com/claude-code)
10 tasks done
`issparse(::AbstractArray)` recurses on `parent`, which need not be an array. Since `vcat`, `hcat` and `hvcat` of any `AbstractVecOrMat` call `issparse`, concatenating such arrays threw a `MethodError`. Fixes #1191
ViralBShah
force-pushed
the
an/issparse-fallback
branch
from
November 22, 2026 14:42
b5f4aea to
d00b07c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 16 16
Lines 10759 10759
=======================================
Hits 10649 10649
Misses 110 110 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ViralBShah
added a commit
that referenced
this pull request
Nov 22, 2026
Julia's CI stopped building 32-bit Windows on Nov 18 (JuliaCI/julia-buildkite#797, following the [Discourse announcement](https://discourse.julialang.org/t/phasing-out-julia-support-for-32-bit-windows/137912) that 1.13 is the last release with 32-bit Windows binaries). The last win32 nightly is `julia-publish` build 11438, for `dffa1584150`. **Before** `julia-latest-win32.zip` was last modified on Nov 18, while the other nightlies are current: ``` winnt/x86/julia-latest-win32.zip last-modified: Wed, 18 Nov 2026 09:16:40 GMT winnt/x64/julia-latest-win64.zip last-modified: Sun, 22 Nov 2026 12:29:29 GMT linux/x86/julia-latest-linux32.tar.gz last-modified: Sun, 22 Nov 2026 12:19:36 GMT ``` So `test (windows-latest, x86, nightly)` runs 1.15.0-DEV.831 while every other job runs DEV.904. It passes on #1192 without seeing the LinearAlgebra bumps that fail the other jobs, and on #1186 SparseArrays fails to precompile: ``` Julia Version 1.15.0-DEV.831 Commit dffa158415 (2026-11-18 07:58 UTC) ERROR: LoadError: UndefVarError: `_aliasparts` not defined in `LinearAlgebra` ``` **After** There is no Windows x86 job. The matrix lists all four runners under `os` with `julia-arch: default`, which `setup-julia` resolves to the runner's own architecture, and 32-bit Linux is the one `include` that sets an architecture: ``` test (ubuntu-latest, default, nightly) coverage test (windows-latest, default, nightly) test (macOS-latest, default, nightly) check-bounds=yes test (ubuntu-26.04-arm, default, nightly) test (ubuntu-latest, x86, nightly) ``` `julia-arch` stays a matrix key so that the x86 `include` adds a job instead of merging into the 64-bit Linux one. 32-bit builds are still tested on Linux, whose nightly is current, and `test/AGENTS.md` now names that job as the source of the 32-bit standard coverage. The required checks in the `main` ruleset follow the new job names: `test (windows-latest, x86, nightly)` is removed, and the macOS, Linux x64 and Windows x64 checks are now the `default` ones. Release branches test their own Julia release and are unaffected, so no backport. *This pull request was written by generative AI (Claude Code).* 🤖 Generated with [Claude Code](https://claude.com/claude-code) (cherry picked from commit ac81ca0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1191.
Before
After
issparse(::AbstractArray)recurses onparent(A), which need not be an array. Since #890 thevcat,hcatandhvcatof anyAbstractVecOrMatcallissparse, so concatenating such arrays threw as soon as SparseArrays was loaded. The recursion now stops withfalsewhen the parent is not an array. The issue suggested a catch-allissparse(::Any) = false; that is left out, soissparseof a non-array still throws.This should be backported to 1.14: the error breaks DataFrames.jl on 1.14.0-beta1, where
keys(::GroupedDataFrame)is anAbstractVectorwhose parent is theGroupedDataFrame. With this branch on nightly, the failing DataFrames expression[keys(groupby(df, [:a, :b])); keys(groupby(df, :a))]returns aVectorof the four keys.This pull request was written by generative AI (Claude Code).