Repository navigation
Conversation
AIRCRFTA.SIF (Ph. Toint's SIF input of problem 9 in J. J. Moré, "A collection of nonlinear model problems") fixes the three controls through their bounds, elevator = 0.1, aileron = 0 and rudderdf = 0, and starts each of them at its fixed value, with the five states at zero. The ADNLPProblems and PureJuMP implementations started the elevator at 0, outside its bounds 0.1 <= elevator <= 0.1. The starting point is now (0, 0, 0, 0, 0, 0.1, 0, 0) in both implementations. It satisfies the variable bounds, and the constraint values there are (0, -2.837, 0, -0.1168, 0). See JuliaSmoothOptimizers#37. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both localized changes match the existing fixed bounds and preserve consistency between implementations.
0 open findings
What changed in this PR
Corrects aircrfta initialization so the fixed elevator starts within its bounds in both implementations.
Changes:
- Sets the elevator’s starting value to
0.1in ADNLPProblems and PureJuMP. - Leaves bounds and problem equations unchanged.
| File | Description |
|---|---|
| src/PureJuMP/aircrfta.jl | Sets the elevator variable’s start to 0.1. |
| src/ADNLPProblems/aircrfta.jl | Sets the sixth starting-point component to 0.1. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Closing this in preference to the two-commit #479 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIRCRFTA.SIF (Ph. Toint's SIF input of problem 9 in J. J. Moré, "A collection of nonlinear model problems") fixes the three controls through their bounds, elevator = 0.1, aileron = 0 and rudderdf = 0, and starts each of them at its fixed value, with the five states at zero. The ADNLPProblems and PureJuMP implementations started the elevator at 0, outside its bounds 0.1 <= elevator <= 0.1.
The starting point is now (0, 0, 0, 0, 0, 0.1, 0, 0) in both implementations. It satisfies the variable bounds, and the constraint values there are (0, -2.837, 0, -0.1168, 0).
See #37.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com