Repository navigation
Conversation
On macOS AArch64 with libquadmath, this provides a performance improvement: median 477 ns on this branch vs. 880 ns on master. On FreeBSD AArch64 with libm, the performance on this branch is identical to master, about 610 ns for both. (Note that the Julia version used on macOS and FreeBSD here differed: 1.12.7 on macOS and 1.14.0-DEV.3218 on FreeBSD.)
stevengj
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS AArch64 (libquadmath
sincosq) with Julia 1.12.7, this provides a performance improvement: median 477 ns on this branch vs. 880 ns on master. On FreeBSD AArch64 (libmsincosl) with Julia 1.14.0-DEV.3218, the performance on this branch is identical to master, about 610 ns for both. So wrapping the library function is as good or better than callingsinandcosseparately, which is not surprising.