Repository navigation
Improve accuracy of norm(::MathType{<:FixedPoint}) - #214
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 98.00% 98.05% +0.05%
==========================================
Files 3 3
Lines 250 257 +7
==========================================
+ Hits 245 252 +7
Misses 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kimikage
force-pushed
the
norm_accuracy
branch
from
October 21, 2026 13:12
8e386ba to
e53f46c
Compare
Collaborator
Author
julia> @btime norm(rgb) setup=(rgb=rand(RGB{Float32}));
27.309 ns (0 allocations: 0 bytes) # before
9.000 ns (0 allocations: 0 bytes) # after
julia> versioninfo()
Julia Version 1.13.2
Commit 45b6d15e34 (2026-10-14 20:33 UTC)
Build Info:
Official https://julialang.org release
Platform Info:
OS: Windows (x86_64-w64-mingw32)
CPU: 8 × 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
WORD_SIZE: 64
LLVM: libLLVM-20.1.8 (ORCJIT, tigerlake)
GC: Built with stock GC
Threads: 1 default, 1 interactive, 1 GC (on 8 virtual cores) |
kimikage
force-pushed
the
norm_accuracy
branch
2 times, most recently
from
October 21, 2026 15:37
f105e6f to
e7966a8
Compare
kimikage
force-pushed
the
norm_accuracy
branch
from
October 21, 2026 15:59
e7966a8 to
7b4227e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183
This does not change the return type. (cf. Issue #213)
This also specializes the cases for
AbstractGrayand wherep==2.