Update for upstream version 1.6.1 by j-fu · Pull Request #73 · JuliaGeometry/TetGen.jl

j-fu · 2026-09-24T13:17:43Z

While the API stays the same, the behavior of the upstream version of tetgen changed quite a bit between 1.5 and 1.6. This is why we make a breaking verision here and and explicetely support
1.5 and 1.6 versions of the upstream jll.

Addresses #47

* adapt runtests to slightly different grid output

Check for size() of point list in RawFacet

* throw an error if it is 1.5. With an updated build for TetGen_jll 1.5.4+1 or 1.5.5, we may remove this.

Copilot

Copilot review overview

🟡 Changes recommended

Unresolved critical pointer-lifetime and moderate compatibility, example, and test issues remain.

Review effort: Lite
Findings: 1 · 2 · 4

Open (7)

Keep conversion buffers alive during nested ccall · New
Retain flags for constrained cut-prism tetrahedralization · New
Pass tetmesh to save_tetgen in the test · New
Fix typo in changelog: suppoirt to support · New
Remove unreachable second return statement · New
Fix API docstring typo: reportst to reports · New
Correct holelist shape description · New

What changed in this PR

Updates TetGen.jl for upstream 1.6.1 while retaining 1.5.4 compatibility and adds save_tetgen input serialization.

Changes:

Adds serialization support across TetGen input types.
Adds tests for supported upstream versions.
Updates documentation, examples, metadata, and changelog.

File	Reviewed change
`test/tetgentests.jl`	Expanded integration and serialization tests.
`test/runtests.jl`	Updated test entry point and compatibility coverage.
`test/runtests-tetgen-1.5.1.jl`	Adds legacy TetGen testing.
`src/TetGen.jl`	Exports `save_tetgen`.
`src/rawtetgenio.jl`	Adds raw input serialization and hole handling.
`src/jltetgenio.jl`	Adds Julia IO conversion and serialization.
`src/cpptetgenio.jl`	Adds C++ IO serialization support.
`src/api.jl`	Adds mesh-level save functionality.
`README.md`	Documents supported versions and bug-report workflow.
`Project.toml`	Updates package version and dependency compatibility.
`examples/examples.jl`	Updates facet-hole and cut-prism examples.
`CHANGELOG.md`	Records the release changes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix typo in comment regarding bug reports. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Removed redundant return statement in save_tetgen function. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update changelog to include recent changes and maintain formatting. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

j-fu · 2026-09-26T21:45:19Z

I want to register this as 3.0 (breaking) as tetgen upstream versions create quantitativelx different grids from the same input. Furthermore this PR keeps upstream version 1.5.1 supported.

See also the discussion in #47

@pjaap

Bumps [JuliaRegistries/TagBot](https://github.com/juliaregistries/tagbot) from 1.25.11 to 1.25.13. - [Release notes](https://github.com/juliaregistries/tagbot/releases) - [Commits](JuliaRegistries/TagBot@cded326...ffef328) --- updated-dependencies: - dependency-name: JuliaRegistries/TagBot dependency-version: 1.25.13 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

* adapt runtests to slightly different grid output

Check for size() of point list in RawFacet

* throw an error if it is 1.5. With an updated build for TetGen_jll 1.5.4+1 or 1.5.5, we may remove this.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix typo in comment regarding bug reports. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Removed redundant return statement in save_tetgen function. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update changelog to include recent changes and maintain formatting. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…into jf/upstream-161

j-fu added 4 commits September 23, 2026 15:57

Update upstream version to v1.6.1

032236d

* adapt runtests to slightly different grid output

Add save_poly and save_nodes methods

a39ecba

Check for size() of point list in RawFacet

fix cutprism example

729e62b

Vheck for TetGen_jll version in save_ methods.

2753ee3

* throw an error if it is 1.5. With an updated build for TetGen_jll 1.5.4+1 or 1.5.5, we may remove this.

j-fu marked this pull request as draft September 24, 2026 13:51

j-fu added 3 commits September 25, 2026 23:14

Remove 1.6 check as we now can use the 1.5.4 jll

7b9f633

Update version to 3.0

903c912

Test with both 1.5.1 and 1.6.1 tetgen versions

290fd02

j-fu force-pushed the jf/upstream-161 branch from 032ada6 to 290fd02 Compare September 25, 2026 21:52

j-fu added 2 commits September 26, 2026 00:14

Update README, docs

1727189

Update Readme + changelog

86c4643

j-fu requested a lite review from Copilot September 26, 2026 20:59

Copilot started reviewing on behalf of j-fu September 26, 2026 20:59 View session

Copilot AI reviewed Sep 26, 2026

View reviewed changes

Comment thread src/jltetgenio.jl Outdated

Comment thread examples/examples.jl Outdated

Comment thread test/tetgentests.jl Outdated

Comment thread CHANGELOG.md Outdated

Comment thread src/api.jl

Comment thread src/cpptetgenio.jl Outdated

Comment thread src/rawtetgenio.jl Outdated

j-fu and others added 8 commits September 26, 2026 23:25

Preserve cinput during save_tetgen call

c262a6d

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix test to save tetmesh instead of mesh

cfc50f7

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Correct typo in save_tetgen function comment

c3ff73d

Fix typo in comment regarding bug reports. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update documentation for holelist array in rawtetgenio.jl

29147ea

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Refactor save_tetgen to remove unnecessary return

ac28aa0

Removed redundant return statement in save_tetgen function. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Change tetrahedralize parameter from 'p' to 'paqAQ'

7020e31

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Revise CHANGELOG.md for clarity and updates

90ddad4

Update changelog to include recent changes and maintain formatting. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix dos line endings in changelog introduced by copilot

2d572bb

j-fu marked this pull request as ready for review September 26, 2026 21:39

dependabot Bot and others added 6 commits October 8, 2026 17:25

Update upstream version to v1.6.1

f6974f5

* adapt runtests to slightly different grid output

Add save_poly and save_nodes methods

e5cc459

Check for size() of point list in RawFacet

fix cutprism example

44099c8

Vheck for TetGen_jll version in save_ methods.

8c917ce

* throw an error if it is 1.5. With an updated build for TetGen_jll 1.5.4+1 or 1.5.5, we may remove this.

Remove 1.6 check as we now can use the 1.5.4 jll

85d2184

j-fu and others added 13 commits October 8, 2026 17:27

Update version to 3.0

e36c1a9

Test with both 1.5.1 and 1.6.1 tetgen versions

64f1080

Update README, docs

0e1cd59

Update Readme + changelog

47a081b

Preserve cinput during save_tetgen call

346cd14

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix test to save tetmesh instead of mesh

afb4751

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Correct typo in save_tetgen function comment

f4d22bb

Fix typo in comment regarding bug reports. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update documentation for holelist array in rawtetgenio.jl

bd14a93

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Refactor save_tetgen to remove unnecessary return

b621398

Removed redundant return statement in save_tetgen function. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Change tetrahedralize parameter from 'p' to 'paqAQ'

72ab225

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Revise CHANGELOG.md for clarity and updates

1e79635

Update changelog to include recent changes and maintain formatting. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix dos line endings in changelog introduced by copilot

661c673

Merge branch 'jf/upstream-161' of github.com:JuliaGeometry/TetGen.jl …

fab4d49

…into jf/upstream-161

j-fu merged commit 84517a9 into master Oct 8, 2026
11 checks passed

j-fu deleted the jf/upstream-161 branch October 8, 2026 15:45

Navigation Menu

Repository navigation

Update for upstream version 1.6.1 - #73

Update for upstream version 1.6.1#73
j-fu merged 36 commits into
masterfrom
jf/upstream-161

j-fu commented Sep 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

j-fu commented Sep 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

j-fu commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

j-fu commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

j-fu commented Sep 24, 2026 •

edited

Loading

j-fu commented Sep 26, 2026 •

edited

Loading