Skip to content

Create missing directories in the LMDBDict constructor. - #79

Merged
maleadt merged 1 commit into
mainfrom
tb/lmdbdict_mkpath
Sep 1, 2026
Merged

maleadt merged 1 commit into
mainfrom
tb/lmdbdict_mkpath

Conversation

@maleadt

@maleadt maleadt commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

LMDB's mdb_env_open requires the environment directory to already exist, so following the README example with a fresh path failed with LMDBError(2): No such file or directory. Since LMDBDict presents a persistent Dict abstraction, create the directory on writable opens; readonly opens still error on a missing path.

Fixes #76

LMDB's mdb_env_open requires the environment directory to already
exist, so following the README example with a fresh path failed with
LMDBError(2): No such file or directory. Since LMDBDict presents a
persistent Dict abstraction, create the directory on writable opens;
readonly opens still error on a missing path.
@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.64%. Comparing base (0a0ea8d) to head (6372c76).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   80.62%   80.64%   +0.02%     
==========================================
  Files           9        9              
  Lines         836      837       +1     
==========================================
+ Hits          674      675       +1     
  Misses        162      162              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt
maleadt merged commit ee2d444 into main Sep 1, 2026
10 checks passed
@maleadt
maleadt deleted the tb/lmdbdict_mkpath branch September 1, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot create new database from Dict API

1 participant