Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that same-type
Realvalues use===when matching a sentinel. A floating-point NaN sentinel therefore matches its own representation; other NaN representations remain data. This explains the behavior reported in #104 and documents normalization when every input NaN should meanmissing.Runtime behavior is unchanged. Replacing this comparison with
isequalwould discard the distinction between the sentinel and other stored NaNs.Validation:36 local checks cover Float16/32/64 sentinel matching, preservation of other NaN representations, assignment, normalization, and signed zero on Julia1.6.7 and1.12.6. No runtime or test files changed.
Co-authored by Codex