Got partial evaluation mostly working#21
Open
ygrignon-sfdc wants to merge 4 commits intoJoffref:joffref/partial_evalfrom
Open
Got partial evaluation mostly working#21ygrignon-sfdc wants to merge 4 commits intoJoffref:joffref/partial_evalfrom
ygrignon-sfdc wants to merge 4 commits intoJoffref:joffref/partial_evalfrom
Conversation
- Add tests in Go
Got partial evaluation mostly working
Added tests for partial evaluation with missing action or missing con…
Owner
|
Hey @ygrignon-sfdc!! Thanks for opening this PR, but the impact of this Cedar version upgrade should be considered, as it brings a lot of breaking changes in the API. I'll dig into it further soon. Please signoff your commits, in order to run tests. It'll help me know better how much this upgrade is affecting the current release. |
Owner
|
Any update @ygrignon-sfdc? 👍 |
Repository owner
deleted a comment
Jan 14, 2024
Repository owner
deleted a comment
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really meant as suggestions and still has a major issue of running into "unexpected end of input" when executing a partial evaluation based on missing (empty string in this implementation) principal or resource. Didn't try with missing action or context attributes though.