test: add native functional coverage#290
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Debug iOS simulator tests need
FORCE_BUNDLING=1; without it the app starts withNo bundle URL present. The CI test step now sets that explicitly.Validation
yarn test --runInBandyarn typecheck --pretty falsenpm run prepackyarn prettier --check --ignore-unknown .github/workflows/ci.yml src/__tests__/index.test.ts android/src/main/java/com/jimmydaddy/imagemarker/ImageMarkerManager.kt android/src/main/java/com/jimmydaddy/imagemarker/ImageMarkerRenderer.kt example/android/app/build.gradle example/android/app/src/androidTest/java/com/imagemarkerexample/ImageMarkerRendererTest.kt && git diff --checkcd example/android && ./gradlew :react-native-image-marker:compileDebugKotlin :app:compileDebugAndroidTestKotlin --stacktracecd example/android && ./gradlew test --stacktracecd example/android && ./gradlew connectedCheck --stacktracecd example/android && ./gradlew assembleRelease --stacktracecd example/ios && FORCE_BUNDLING=1 xcodebuild -workspace ImageMarkerExample.xcworkspace -scheme ImageMarkerExample -sdk iphonesimulator -destination id=1E771580-D017-4A27-9999-59F6C2563A4C test | xcprettycd example/ios && xcodebuild -workspace ImageMarkerExample.xcworkspace -scheme ImageMarkerExample -configuration Release -sdk iphonesimulator -destination id=1E771580-D017-4A27-9999-59F6C2563A4C | xcpretty