fix(jans-cli-tui): only one of one time use or rotate can be checked for SSA - #14626
Conversation
Signed-off-by: Mustafa Baser <mbaser@mail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe SSA edit dialog now uses stored checkbox widgets with a shared handler that prevents “One Time Use” and “Rotate SSA” from being enabled simultaneously. ChangesSSA checkbox behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@jans-cli-tui/cli_tui/plugins/010_auth_server/ssa.py`:
- Around line 471-486: Before constructing the widgets in the SSA initialization
flow, normalize the stored one_time_use and rotate_ssa values so they cannot
both remain true; apply an explicit precedence rule, preserving the existing
callback behavior for later user changes. Use the normalized values when setting
checked in the one_time_use_checkbox and rotate_checkbox definitions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: bc1c5c45-0de7-4296-a803-dead885a7c15
📒 Files selected for processing (1)
jans-cli-tui/cli_tui/plugins/010_auth_server/ssa.py
…ting the widgets Signed-off-by: Mustafa Baser <mbaser@mail.com>
|



Prepare
Description
Target issue
closes #14625
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:to indicate documentation changes or if the below checklist is not selected.Summary by CodeRabbit