Repository navigation
chore(tests): generic names in two fixtures - #73
Merged
Merged
Conversation
The log redaction tests used a real Windows account name in their sample paths, and a launcher fixture named a real person in a to-do. Neither mattered to what was being tested. They are now alex and call the bank.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
CI for a28f0c0: all jobs passed
Tests: 518 passed, 0 failed, 0 skipped, 518 total. This comment updates itself on every push. Full run. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test fixtures carried real details that the tests did not need:
tests/logger.test.jsused a real Windows account name in the sample paths it redacts. Nowalex.tests/commands.test.jsnamed a real person in a sample to-do. Nowcall the bank.No behaviour changes.
npm test: 514 pass, 0 fail, 4 skipped. Lint clean.The old values remain in git history. Removing them there would mean rewriting published history, which this does not attempt.