Skip to content

Mempool fixes #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coot merged 21 commits into from
Jan 19, 2026
Merged

Mempool fixes #19

coot merged 21 commits into from
Jan 19, 2026

Conversation

@coot
Copy link
Contributor

@coot coot commented Jan 15, 2026 •
edited
Loading

List of changes

  • Updated README.md file
  • nix: removed pre-commit-hook
  • SigId Show & ToJSON instances
  • Added LocalMsgNotificationServerTracer
  • Using simple mempool with persistent indices
  • Sig validation: refactoring
  • Sig: Show and ToJSON instances
  • LocalStateQueryClient: cleaned all warnings
  • Added a haddock
  • Removed not needed constraint
  • configuration: default traces

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Jan 15, 2026
@coot coot linked an issue Jan 15, 2026 that may be closed by this pull request
Inconsistent diffusion of messages #10
Closed
@coot coot self-assigned this Jan 16, 2026
@coot coot marked this pull request as ready for review January 16, 2026 15:35
@coot coot force-pushed the coot/mempool-fixes branch from 2e42c7e to baffb58 Compare January 16, 2026 15:45
crocodile-dentist
crocodile-dentist approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coot coot force-pushed the coot/mempool-fixes branch from baffb58 to 312a2ce Compare January 16, 2026 16:21
@coot coot enabled auto-merge January 16, 2026 16:33
@coot coot force-pushed the coot/mempool-fixes branch from a78005c to f477e2b Compare January 17, 2026 10:53
@coot coot disabled auto-merge January 17, 2026 10:58
coot added 10 commits January 17, 2026 12:01
@coot
validateSig: refactoring
153b2f8 
Also fixed a bug in signature validation: the `PoolValidationCtx
{ vctxOcertMap }` was not updated during validation.
@coot
Using simple mempool with persistent indices
1b78f24
@coot
Added LocalMsgNotificationServerTracer
d9e1d1a
@coot
SigId Show & ToJSON instances
3f8d18c 
Show first 10 bytes (in hex).
@coot
nix: removed pre-commit-hook
0ed644f
@coot
Updated README.md file
8b1e353
@coot
nix: use -Werror on hydra
c78f233
@coot
Small changes
fbc9b39 
* fixed Show Sig instance
* code style
@coot
Improved prop_validateSig
7387fbd 
Check that `validteSig` fails when it should.
@coot
validateSig: code style, improved comments
91c12c0
@coot coot force-pushed the coot/mempool-fixes branch from f477e2b to 64805a6 Compare January 17, 2026 11:01
@coot coot force-pushed the coot/mempool-fixes branch from 50d8bae to 468272a Compare January 17, 2026 13:27
crocodile-dentist
crocodile-dentist approved these changes Jan 19, 2026
View reviewed changes
coot added 4 commits January 19, 2026 13:01
@coot
validateSig: simplified validation logic
8cb68a3 
We can handle acceptable clock skew and valid time in a single case.
@coot
Added changelog entry
dd2e916
@coot
Fixed ghc-9.12 support
fc3103e 
Build with `ghc9122` on `Hydra`.
@coot
nix: refactored outputs
45349b6 
Now updating the default compiler only requires a single change in,
in the `nix/project.nix` file.

For some reason this patch added static builds to hydra :).
@coot coot force-pushed the coot/mempool-fixes branch from 468272a to 45349b6 Compare January 19, 2026 12:01
@coot coot added this pull request to the merge queue Jan 19, 2026
Merged via the queue into main with commit 07d98a5 Jan 19, 2026
100 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ouroboros Network Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crocodile-dentist crocodile-dentist crocodile-dentist approved these changes

Assignees

@coot coot

Labels

None yet

Projects

Ouroboros Network
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent diffusion of messages

3 participants

@coot @crocodile-dentist