Potential fix for code scanning alert no. 23: Use of potentially dangerous function#328
Merged
Potential fix for code scanning alert no. 23: Use of potentially dangerous function#328
Conversation
…erous function Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
|
Target CPP Coverage: 68.113% Target Python Coverage: 97.94% |
Contributor
|
Target CPP Coverage: 68.1076% Target Python Coverage: 97.94% |
Contributor
|
Target CPP Coverage: 68.0916% Target Python Coverage: 97.94% |
sys-vdms
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/IntelLabs/vdms/security/code-scanning/23
In general, the fix is to avoid
asctimeand other non‑reentrant time formatting functions, and instead use thread‑safe, caller‑supplied buffers or C++ iostream formatting (for example,std::put_time) to convertstruct tmto a string.For this specific code in
QueryHandlerPMGD::regular_run_autoreplicate, the simplest non‑disruptive change is:std::timeandstd::localtimeto populate astd::tm.oss << asctime(&tm);withoss << std::put_time(&tm, "%c");(or another suitable format), which formats the time directly into theostringstreamwithout any static internal buffer.<iomanip>at the top of the file so thatstd::put_timeis available.This preserves the existing behavior of generating a human‑readable timestamp (still containing spaces and possibly newlines, which are then stripped by the following
erasecalls) while eliminating the dangerousasctimecall. All other logic (sanitizing the name string, building the command, etc.) remains unchanged.Suggested fixes powered by Copilot Autofix. Review carefully before merging.