Potential fix for code scanning alert no. 24: Use of potentially dangerous function#327
Merged
Potential fix for code scanning alert no. 24: Use of potentially dangerous function#327
Conversation
…erous function Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…erous function Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
|
Target CPP Coverage: 68.113% Target Python Coverage: 97.94% |
sys-vdms
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/IntelLabs/vdms/security/code-scanning/24
To fix the issue, replace the use of
std::localtimewith the thread-safe versionlocaltime_r, which requires explicit allocation of astruct tmon the stack and then passing its pointer to receive the result. We need to edit line 269 ofsrc/Server.cc, allocate a localstruct tmvariable, and uselocaltime_rto populate it. The code that usesnow_tmremains unchanged, except we reference our stack variable instead of the potentially shared static buffer.Typically, C++ standard library does not provide a direct wrapper for
localtime_r, but POSIX (localtime_r) is broadly available on Linux and macOS, which matches the includes and style here. We'll need to include<time.h>for the function signature in case it has not been included. The change is localized to the region around line 269; no other changes are needed in file or method.Suggested fixes powered by Copilot Autofix. Review carefully before merging.