FFI: fix return of large bitvectors#150
Merged
Merged
Conversation
For FFI imported functions that return more than 64 bits, like this function F() -> (Bits(512), Boolean); We need to generate an FFI wrapper that includes a line like this uint64_t c_r0[8]; bool c_r1; F(c_r0, &c_r1); Note that c_r1 requires '&' to pass a pointer while c_r0 must not have '&' because C/C++ compilers will promote the array to a pointer.
nikolaykosarev
approved these changes
Jun 22, 2026
Co-authored-by: Nikolay Kosarev <nikolay.kosarev@intel.com> Signed-off-by: Alastair Reid <alastair.d.reid@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For FFI imported functions that return more than 64 bits, like this
function F() -> (Bits(512), Boolean);
We need to generate an FFI wrapper that includes a line like this
uint64_t c_r0[8];
bool c_r1;
F(c_r0, &c_r1);
Note that c_r1 requires '&' to pass a pointer while c_r0 must not have '&' because C/C++ compilers will promote the array to a pointer.