Correctly track relative links when navigating - #465
Merged
Conversation
Collaborator
|
will take a look tomorrow, thanks! |
Collaborator
|
pulled the second commit into its own PR (#467). will take a closer look at the other bits tomorrow 🧚 |
Fixes Inlyne-Project#398 Navigation failing with relative paths
CosmicHorrorDev
approved these changes
Jul 22, 2026
CosmicHorrorDev
left a comment
CosmicHorrorDev
left a comment
Collaborator
There was a problem hiding this comment.
tweaked the commit message, but all the code looks great. thanks!
tested with the reproduction listed in the issues. main fails and this PR works perfectly including the file watcher
Contributor
Author
|
Thank you! |
CosmicHorrorDev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigation fails with relative pathsEnsure that
std::env::set_current_diris called when following a relative .md link. Canonicalize the path first to ensure it's unambiguously correct for the file watcher and the make_next history function.