Skip to content

chore: remove sandbox type - #136

Merged
InftyAI-Agent merged 2 commits into
InftyAI:mainfrom
kerthcet:cleanup/remove-sandbox
Oct 10, 2026
Merged

chore: remove sandbox type#136
InftyAI-Agent merged 2 commits into
InftyAI:mainfrom
kerthcet:cleanup/remove-sandbox

Conversation

@kerthcet

@kerthcet kerthcet commented Oct 10, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Let's not reinvent new things.

Does this PR introduce a user-facing change?

@kerthcet
remove sandbox type
5795e90 
Signed-off-by: kerthcet <kerthcet@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 10, 2026 22:37
Copilot AI reviewed Oct 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c4cf46a1-cc38-4501-b4d1-0289f8b557de
📥 Commits

Reviewing files that changed from the base of the PR and between ef10e49 and 85fd993.

📒 Files selected for processing (19)
  • api/v1alpha1/groupversion_info.go
  • api/v1alpha1/sandbox_types.go
  • api/v1alpha1/sandboxset_types.go
  • api/v1alpha1/zz_generated.deepcopy.go
  • cmd/main.go
  • config/crd/bases/nebula.inftyai.com_sandboxes.yaml
  • config/crd/bases/nebula.inftyai.com_sandboxsets.yaml
  • config/crd/kustomization.yaml
  • config/rbac/role.yaml
  • config/samples/sandbox.yaml
  • config/samples/sandboxset.yaml
  • docs/architecture.md
  • internal/controller/concurrency.go
  • internal/controller/samples_provisionable_test.go
  • internal/controller/sandbox_controller.go
  • internal/controller/sandbox_controller_test.go
  • internal/controller/sandbox_validation_test.go
  • internal/controller/sandboxset_controller.go
  • internal/controller/sandboxset_controller_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2026
@kerthcet
address comments
85fd993 
Signed-off-by: kerthcet <kerthcet@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 10, 2026 22:42
Copilot AI reviewed Oct 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kerthcet

kerthcet commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

/lgtm
/kind cleanup

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Oct 10, 2026
InftyAI-Agent
InftyAI-Agent approved these changes Oct 10, 2026
View reviewed changes

@InftyAI-Agent InftyAI-Agent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: PR has both lgtm and approved labels

@InftyAI-Agent
InftyAI-Agent merged commit ec36450 into InftyAI:main Oct 10, 2026
27 checks passed
@kerthcet
kerthcet deleted the cleanup/remove-sandbox branch October 10, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@InftyAI-Agent InftyAI-Agent InftyAI-Agent approved these changes

Assignees

@kerthcet kerthcet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kerthcet @InftyAI-Agent