Skip to content

feat: add examples for InfisicalStaticSecret#100

Merged
mathnogueira merged 2 commits into
mainfrom
matheus/staticsecret-examples
Jul 9, 2026
Merged

feat: add examples for InfisicalStaticSecret#100
mathnogueira merged 2 commits into
mainfrom
matheus/staticsecret-examples

Conversation

@mathnogueira

Copy link
Copy Markdown
Contributor

Adds an examples folder containing the full Kubernetes manifest for each auth type.

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-kubernetes-operator-100-feat-add-examples-for-infisicalstaticsecret

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds a new examples/v1beta1/infisicalstaticsecret/ directory with complete, copy-paste-ready Kubernetes manifests for each supported auth method (AWS IAM, Azure, GCP IAM, GCP ID Token, Kubernetes, LDAP, Universal). Each file covers the full four-resource chain: credentials Secret → InfisicalConnectionInfisicalAuthInfisicalStaticSecret.

  • The kubernetes-auth example correctly includes a ServiceAccount, a ClusterRoleBinding (binding to system:auth-delegator with namespace: default on the subject), and wires the SA into InfisicalAuth.spec.kubernetes.serviceAccountRef.
  • The gcp-iam-auth example ships with a companion README.md explaining how to mount the service account key JSON into the operator pod via Helm, and the serviceAccountKeyFilePath in the YAML matches that mount path.
  • All examples use placeholder values annotated with # replace this and default to the public Infisical SaaS endpoint.

Confidence Score: 5/5

Pure documentation/example change with no operator logic modified — safe to merge.

All eight files are example manifests and documentation only. The previously raised ClusterRoleBinding subject namespace omission is now correctly included. No logic regressions are possible from this change.

No files require special attention.

Important Files Changed

Filename Overview
examples/v1beta1/infisicalstaticsecret/kubernetes-auth/infisicalstaticsecret.yaml Full Kubernetes auth example with ServiceAccount, ClusterRoleBinding, InfisicalAuth, and InfisicalStaticSecret; ClusterRoleBinding subject now correctly includes namespace: default.
examples/v1beta1/infisicalstaticsecret/gcp-iam-auth/infisicalstaticsecret.yaml GCP IAM auth example using a service account key file; path /etc/gcp/service-account-key.json aligns with the companion README's Helm volume mount instructions.
examples/v1beta1/infisicalstaticsecret/gcp-iam-auth/README.md Supplementary README explaining how to create the GCP SA key Secret and mount it into the operator pod via Helm; clear and accurate.
examples/v1beta1/infisicalstaticsecret/ldap-auth/infisicalstaticsecret.yaml LDAP auth example; credentials (username, password, identityId) are stored in a single Secret with placeholder # replace this annotations — correct standard practice.
examples/v1beta1/infisicalstaticsecret/aws-iam-auth/infisicalstaticsecret.yaml AWS IAM auth example; well-structured four-manifest chain referencing the public Infisical SaaS endpoint.
examples/v1beta1/infisicalstaticsecret/azure-auth/infisicalstaticsecret.yaml Azure managed identity auth example; follows the same correct four-manifest pattern as the other auth types.
examples/v1beta1/infisicalstaticsecret/gcp-id-token-auth/infisicalstaticsecret.yaml GCP ID Token auth example; correctly uses the gcp-id-token method with gcpIdToken.identityIdRef.
examples/v1beta1/infisicalstaticsecret/universal-auth/infisicalstaticsecret.yaml Universal auth example; both clientId and clientSecret are stored in a single well-labeled Secret with placeholder values.

Reviews (2): Last reviewed commit: "use default namespace" | Re-trigger Greptile

@mathnogueira mathnogueira requested review from jakehulberg and varonix0 and removed request for varonix0 July 1, 2026 23:34
@jakehulberg

Copy link
Copy Markdown

@greptile re-review pls

@jakehulberg jakehulberg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mathnogueira

Copy link
Copy Markdown
Contributor Author

Thanks @jakehulberg

@mathnogueira mathnogueira merged commit 6bfdfc0 into main Jul 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants