fix(sync-jp-docs): improve translation coverage in angular and xplat workflows#357
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the JP sync agent workflows so more English documentation sources (including generated-template inputs) are considered “in-scope” for translation, improving translation coverage for both xplat and Angular docs.
Changes:
- xplat: add a Step 1b TOC-based filter and explicitly include
components/grids/_shared/MDX templates in the translatable set. - Angular: extend Step 1b filtering to include
grids_templates/MDX sources and clarify the produced allowlist. - Regenerate/upgrade agentic workflows tooling outputs (lock workflows, maintenance workflow) and adjust merge strategy for generated lock workflows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/sync-jp-docs-xplat.md | Adds TOC-covered-file allowlist generation and includes _shared/ grid templates in translation scope. |
| .github/workflows/sync-jp-docs-xplat.lock.yml | Regenerated compiled workflow for xplat JP sync (tooling/runtime updates). |
| .github/workflows/sync-jp-docs-angular.md | Includes grids_templates/ sources in TOC allowlist logic and updates explanatory text. |
| .github/workflows/sync-jp-docs-angular.lock.yml | Regenerated compiled workflow for Angular JP sync (tooling/runtime updates). |
| .github/workflows/agentics-maintenance.yml | Regenerated maintenance workflow with updated gh-aw version and behavior tweaks. |
| .github/aw/actions-lock.json | Updates pinned gh-aw action SHAs/versions used by generated workflows. |
| .gitattributes | Changes merge strategy for generated *.lock.yml workflows to prefer ours. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChronosSF
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xplat: Added the missing Step 1b TOC filter (angular already had one).
components/grids/_shared/files are explicitly included — they are sourcetemplates expanded by
generate.mjsand were translated in the legacy system.Angular: Extended Step 1b to include
grids_templates/files.These are the canonical source for grid pages —
generate-grids.mjsexpandsthem at build time for every language including JP. The generated per-grid
pages are git-ignored and never reach the diff; previously the TOC-only filter
silently skipped the templates too, leaving them untranslated.
Note: This PR also regenerates the agentic workflow lock files and bumps
gh-aw tooling to v0.80.9. Review the lock file diffs for any unintended
behaviour changes beyond the TOC/template filtering updates above.
Closes #
Checklist:
preview/beta../relative/path.mdIgxSelectComponent,<igx-combo>code blocksfor the names of classes / tags / propertiescode blockscheck-api/mdxnpm commands