Skip to content

fix(sync-jp-docs): improve translation coverage in angular and xplat workflows#357

Merged
ChronosSF merged 3 commits into
vnextfrom
vkombov/sync-jp-docs-grids
Jun 25, 2026
Merged

fix(sync-jp-docs): improve translation coverage in angular and xplat workflows#357
ChronosSF merged 3 commits into
vnextfrom
vkombov/sync-jp-docs-grids

Conversation

@viktorkombov

@viktorkombov viktorkombov commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  1. xplat: Added the missing Step 1b TOC filter (angular already had one).
    components/grids/_shared/ files are explicitly included — they are source
    templates expanded by generate.mjs and were translated in the legacy system.

  2. Angular: Extended Step 1b to include grids_templates/ files.
    These are the canonical source for grid pages — generate-grids.mjs expands
    them at build time for every language including JP. The generated per-grid
    pages are git-ignored and never reach the diff; previously the TOC-only filter
    silently skipped the templates too, leaving them untranslated.

Note: This PR also regenerates the agentic workflow lock files and bumps
gh-aw tooling to v0.80.9. Review the lock file diffs for any unintended
behaviour changes beyond the TOC/template filtering updates above.

Closes #

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in the topic content when it has a valuable update, is new, or is considered preview / beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check if links function by running the check-api/mdx npm commands
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)

@viktorkombov viktorkombov requested a review from ChronosSF June 24, 2026 13:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the JP sync agent workflows so more English documentation sources (including generated-template inputs) are considered “in-scope” for translation, improving translation coverage for both xplat and Angular docs.

Changes:

  • xplat: add a Step 1b TOC-based filter and explicitly include components/grids/_shared/ MDX templates in the translatable set.
  • Angular: extend Step 1b filtering to include grids_templates/ MDX sources and clarify the produced allowlist.
  • Regenerate/upgrade agentic workflows tooling outputs (lock workflows, maintenance workflow) and adjust merge strategy for generated lock workflows.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/sync-jp-docs-xplat.md Adds TOC-covered-file allowlist generation and includes _shared/ grid templates in translation scope.
.github/workflows/sync-jp-docs-xplat.lock.yml Regenerated compiled workflow for xplat JP sync (tooling/runtime updates).
.github/workflows/sync-jp-docs-angular.md Includes grids_templates/ sources in TOC allowlist logic and updates explanatory text.
.github/workflows/sync-jp-docs-angular.lock.yml Regenerated compiled workflow for Angular JP sync (tooling/runtime updates).
.github/workflows/agentics-maintenance.yml Regenerated maintenance workflow with updated gh-aw version and behavior tweaks.
.github/aw/actions-lock.json Updates pinned gh-aw action SHAs/versions used by generated workflows.
.gitattributes Changes merge strategy for generated *.lock.yml workflows to prefer ours.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/sync-jp-docs-xplat.md
Comment thread .github/workflows/sync-jp-docs-angular.md
Comment thread .github/workflows/agentics-maintenance.yml
@ChronosSF ChronosSF merged commit 81684fa into vnext Jun 25, 2026
7 checks passed
@ChronosSF ChronosSF deleted the vkombov/sync-jp-docs-grids branch June 25, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants